Wireshark-bugs: [Wireshark-bugs] [Bug 9261] openSAFETY: Dissection for second crc as well as pla

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 10 Oct 2013 18:17:03 +0000

changed bug 9261

What Removed Added
Attachment #11756 is obsolete   1
Attachment #11756 Flags review_for_checkin?  
Attachment #11759 Flags   review_for_checkin?

Comment # 3 on bug 9261 from 
Created attachment 11759 [details]
openSAFETY: Dissection for second crc as well as plausability check

> I'm not an openSAFETY expert, but I have a couple of questions and
> suggestions regarding that attachment 11756 [details].  First,
> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=11756&action="">
> epan/dissectors/packet-opensafety.c_sec3 refers to ((2^10)-1) but ^ is a
> bitwise xor and not exponentiation so that gets you the value of 7 instead
> of 1023.  You probably want either ((1<<10)-1) or just 1023.

Fixed in updated patch.

You are receiving this mail because:
  • You are watching all bug changes.