[bugzilla-daemon@xxxxxxxxxxxxx]

beroset@mindspring.com changed bug 9261

What	Removed	Added
CC		beroset@mindspring.com

Comment # 1 on bug 9261 from beroset@mindspring.com

I'm not an openSAFETY expert, but I have a couple of questions and suggestions
regarding that attachment 11756 [details].  First,
https://bugs.wireshark.org/bugzilla/attachment.cgi?id=11756&action="">
refers to ((2^10)-1) but ^ is a bitwise xor and not exponentiation so that gets
you the value of 7 instead of 1023.  You probably want either ((1<<10)-1) or
just 1023.

Second, the first CRC has opensafety.crc.data and opensafety.crc.type fields as
well as opensafety.crc.valid field.  Should those other fields exist for the
second crc as well?

Third, it would be most useful to attach a sample trace to this bug report so
that your enhancements can be more easily seen and tested. 

Thanks for your contribution!

---

You are receiving this mail because:

• You are watching all bug changes.