Wireshark-bugs: [Wireshark-bugs] [Bug 9217] STANAG 5066 DTS Layer dissector

Date: Sat, 05 Oct 2013 12:45:54 +0000

Comment # 13 on bug 9217 from
> ...because it appears that S5066-over-TCP just concatenates PDUs and sends
> them over a TCP byte stream without any extra header being added, using the
> sync pattern to separate PDUs.

Thanks a lot Guy, I've made the relevant changes conforming to your
instructions.

> It appears that the dissector introduced by this patch handles what's
> described in Annex C of that spec.

Yeap, the other dissector handles the primitives between SIS(subnetwork
interface sublayer) which was defined in Annex-A and the clients defined in
Annex-F section of the specification. But s5066dts is responsible for DTS(Annex
C) protocol data units' dissection.

By the way, I had asked the following question in an answer to Michael. What
would you recommend about that?

6. Please put crc routines into epan/crc*-tvb.h
I realized that CRC look-up tables were created in wsutil/crc*.h for certain
polynomials. Am I supposed to put the routines directly to the relevant cry*.h
file existing in the directory 'epan' or dump the CRC lookup table of the
specified poly in STANAG 5066 and put it into amidst other tables under a
related wsutil/crc* file with the checksum computation routine in there?


You are receiving this mail because:
  • You are watching all bug changes.