Wireshark-bugs: [Wireshark-bugs] [Bug 9158] LLC: Display I/G and C/R bits in subtree/bitwise vie

Date: Sat, 21 Sep 2013 15:47:33 +0000

changed bug 9158

What Removed Added
Attachment #11599 is obsolete   1
Attachment #11599 Flags review_for_checkin?  
Attachment #11622 Flags   review_for_checkin?

Comment # 1 on bug 9158 from
Created attachment 11622 [details]
Corrected diff for packet-llc.c (please disregard the previous diff file)

Greetings,

I am attaching an updated version of the patch. The previous patch has had two
important issues I did not originally notice:

1.) I have incorrectly used the ti variable in the dissect_llc() for my own
purposes when adding the bitfield tree. The remaining code expected that the ti
still points to the "Logical Link Control" item in the proto tree. As a result,
various items were subsequently incorrectly displayed and highlighted. This
corrected patch uses new local variables dsap_item and ssap_item to avoid
interfering with the existing code.

2.) In the call to proto_tree_add_item() when displaying the CR bit in the
SSAP, I have incorrectly used the offset of 0 instead of 1. As a result, I was
wrongly tapping into the DSAP field instead of SSAP.

I sincerely apologize for letting these issues pass unnoticed. The second patch
rectifies them.

Thank you!

Best regards,
Peter


You are receiving this mail because:
  • You are watching all bug changes.