Comment # 12
on bug 9047
from Pascal Quantin
(In reply to comment #11)
> Created attachment 11530 [details]
> For the whitespace changes, I may have taken Michaels comment a little bit
> to serious and went overboard with them. I did use BeyondCompare to review
> the changes, and they look good to me.
My understanding is that Michael suggested you to remove the extra spaces added
at the end of some lines in your first patch, not to change all the indentation
of the file.
I'm still -1 for tis change due to the reasons I gave in comment #10. If
someone else does not care that much, I will let him commit the patch as-is :)
> "val_to_str_const(svid, asnd_svid_vals, "Unknown"), svid)" -> I have not
> changed, as it should mirror the behaviour of the EPL dissector for OmniPeek
> (also developed by B&R) and by using the hf_fields I could not reproduce the
> same information.
When I replace:
item = proto_tree_add_uint_format_value(epl_tree, hf_epl_asnd_svid, tvb,
offset, 1,
svid, "%s (%d)",
val_to_str_const(svid, asnd_svid_vals, "Unknown"),
svid);
by:
item = proto_tree_add_uint(epl_tree, hf_epl_asnd_svid, tvb, offset, 1,
svid);
I get the exact same output when dissecting 130125111516_AInv_frame2.pcap file.
Am I missing something?
Other than that, it looks good to me.
You are receiving this mail because:
- You are watching all bug changes.