[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	9102
Summary	Typo in the name of a PPPoE tag name
Classification	Unclassified
Product	Wireshark
Version	1.10.1
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	Trivial
Priority	Low
Component	Dissection engine (libwireshark)
Assignee	bugzilla-admin@wireshark.org
Reporter	wsbugzilla2013@live.at

Build Information:
(just a trivial typo in a string - build info not relevant)

--
(It's probably obvious to you, but just in case: Beyond 1.10.1, like I
selected, this typo is found in 1.8.10pre.., 1.10.2pre.., 1.11.x as well.)

Looking at the communication between a DSL router and its DSLAM, I found
Wirehark showing me a PPPoE tag which it calls

"PPP Max Palyload"

This really should read "Payload".

Additionally, for the sake of consistency - and because RFC 4638 as well as
http://www.iana.org/assignments/pppoe-parameters/pppoe-parameters.xhtml spell
it that way - I think that Wireshark should show the official parameter name,
which is hyphenized.

Accordingly, I would like to suggest the following change to the Wireshark
source (line numbers for 1.10.1):

--- epan/dissectors/packet-pppoe.c.orig
+++ epan/dissectors/packet-pppoe.c
@@ -991,7 +991,7 @@
             }
         },
         { &hf_pppoed_tag_max_payload,
-            { "PPP Max Palyload", "pppoed.tags.max_payload", FT_BYTES,
BASE_NONE,
+            { "PPP-Max-Payload", "pppoed.tags.max_payload", FT_BYTES,
BASE_NONE,
                  NULL, 0x0, NULL, HFILL
             }
         },


Would be much appreciated!

Thanks a lot for your time & effort.

 C.

---

      You are receiving this mail because:

• You are watching all bug changes.