Wireshark-bugs: [Wireshark-bugs] [Bug 9055] Support for bitmask set for types FT_INT8, FT_INT16,

Date: Tue, 20 Aug 2013 22:27:49 +0000

Comment # 3 on bug 9055 from
(In reply to comment #1)
> +		no_of_bits = wrs_count_bits(hfinfo->bitmask);
> +		if (integer & (G_GINT64_CONSTANT(1) << (no_of_bits-1)))
> +			integer |= (G_GINT64_CONSTANT(-1) << no_of_bits);
> 
> Why G_GINT64_CONSTANT?
> 
> I assume this code should do sign-extension (it looks weird to do this just
> for single bit), maybe we could just use arithmetic shift?

ah, -1 << bits sorry.

It's ok.


You are receiving this mail because:
  • You are watching all bug changes.