Wireshark-bugs: [Wireshark-bugs] [Bug 9055] Support for bitmask set for types FT_INT8, FT_INT16,

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 20 Aug 2013 21:40:50 +0000

changed bug 9055

What Removed Added
CC   [email protected]

Comment # 1 on bug 9055 from 
+        no_of_bits = wrs_count_bits(hfinfo->bitmask);
+        if (integer & (G_GINT64_CONSTANT(1) << (no_of_bits-1)))
+            integer |= (G_GINT64_CONSTANT(-1) << no_of_bits);

Why G_GINT64_CONSTANT?

I assume this code should do sign-extension (it looks weird to do this just for
single bit), maybe we could just use arithmetic shift?

You are receiving this mail because:
  • You are watching all bug changes.