Wireshark-bugs: [Wireshark-bugs] [Bug 9034] Composite TVBs aren't supported by tvb_find_guint8()

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 19 Aug 2013 18:21:35 +0000

changed bug 9034

What Removed Added
CC   [email protected]

Comment # 5 on bug 9034 from 
(In reply to comment #4)
> Created attachment 11378 [details]
> Add generic find_guint8, pbrk_guint8
> 
> I'd prefer this patch, please test.

With this patch and the tcp-wireshark-file1.trace file, I get a dissector
assert in tvbuff_composite.c file at line 100.
This occurs when the offset is already at the end of the tvb (offset=14311,
packet size=11431).

Adding a quick & dirty
    if (!limit)
        return -1;
at the beginning of tvb_find_guint8_generic() and tvb_pbrk_guint8_generic()
functions allows to get the same dissection as trunk-1.10 branch. But it might
not the cleanest way to handle this use case (but on the other side a memchr
with a size set to 0 - as done for REAL tvbuff - is a NOP operation also).

You are receiving this mail because:
  • You are watching all bug changes.