Michael Mann
changed
bug 9047
| What |
Removed |
Added |
| Attachment #11391 is obsolete |
|
1
|
| Attachment #11391 Flags |
review_for_checkin?
|
|
Comment # 2
on bug 9047
from Michael Mann
Created attachment 11400 [details]
EPL dissector patch update
Made some improvements to current patch including:
1. Remove excessive whitespace at end of line(s). Hopefully I got them all
(manual inspection)
2. Remove NULL checks for trees and items. Unless there is a large group of
proto_tree_add_xxx, the NULL check isn't really saving much and just bloats the
code.
Still need to do:
1. Make Payload values filterable. All of the "integer" types can share the
same display filter name, but the "bytes" type will need to be different. Much
better than a FT_NONE type.
2. If cleaning up, perhaps there are more unnecessary NULL checks for trees and
items in the dissector. I only cleaned up ones in the provided patch.
You are receiving this mail because:
- You are watching all bug changes.