Comment # 8
on bug 9027
from Jakub Zawadzki
(In reply to comment #7)
> Argh, sorry, I was changing the wrong line! I had been replacing the
> "tvb_free(fd_i->tvb_data)" a few lines above instead of the correct
> "tvb_free(old_tvb_data)". This is what happens when you manually apply
> patches :(
>
> Anyways, with the actual patch applied as suggested, I now get:
>
> ** (process:25598): WARNING **: Dissector bug, protocol TCP, in packet 225:
> tvbuff.c:135: failed assertion "!child->next"
Thanks. Ok, so I think we have 5 possibilites:
1/ Fix tcp reassembly code to use only *last* result of fragment_add for given
frame -- and hope not other dissectors are broken
2/ support merging tvb chains in tvb_add_to_chain() [or better some new
function]
3/ replace tvb_new_proxy() with tvb_clone()
4/ add reassembly tvb ;]
5/ add reference counting in tvbs
2 and 3 are the easiest one :) still I'm not happy with 3
You are receiving this mail because:
- You are watching all bug changes.