Comment # 20
on bug 8947
from Simon Zhong
> I made a few minor updates to your patch, but wanted your okay before
> committing.
Thanks Michael, I believe that you made handle_value an argument instead of
global variable? I'm okay with the change. I agree it's better to avoid using
global variable.
> Since I'm unfamiliar with the protocol, I'm still not sure if it makes sense
> to "push" opcode/is_solicited down to handle field (and display
> request/response information info there) or "pull" handle field up (as is
> currently done).
According to RFC 2748, Op Code and Flags are part of Common Header, Handle is
one of the COPS Specific Object, and it's not mandatory, for some Op Codes they
don't even have to specify handle, so I think it's better to keep handle at the
same level of other objects.
You are receiving this mail because:
- You are watching all bug changes.