Wireshark-bugs: [Wireshark-bugs] [Bug 8472] Add support for collectd's high-resolution times.

Date: Fri, 26 Jul 2013 23:24:01 +0000

Comment # 15 on bug 8472 from
Recently I was thinking it could be done a little easier. For now there's no
64-bits values in severity_names, so:

in fill_label_number64() check if value fits in 32 bits ((value >> 32) == 0),
if yes: 
   str = hf_try_val_to_str((guint32) value, hfinfo);
else str = "unknown";

But thanks for implementing 64 bits vals, maybe people will start using it :)


> Feel free to review for cases I missed: I fuzzed fairly thoroughly and looked 
> at a few displayed fields to make sure they were correct, but I didn't check 
> every possible value_string use in the engine.

I'm afraid we need to do checks in more places, if you want to grep for
RANGE_STRING.


You are receiving this mail because:
  • You are watching all bug changes.