Wireshark-bugs: [Wireshark-bugs] [Bug 8908] Strange behavior of tree expand/collapse in packet d

Date: Fri, 26 Jul 2013 18:18:21 +0000

Comment # 31 on bug 8908 from
(In reply to comment #29)
> (In reply to comment #28)
> > One last weirdness: while Shift+Right expands subtrees, Shift+Left does not
> > collapse the subtrees (it only collapses the selected tree).  I don't see a
> > shortcut for Shift+Left but it does work in trunk-1.8 (maybe as a side
> > effect).
> Right.  See also comment 15.

<sigh> I forgot that.

> > It just doesn't feel correct to me.  Thoughts?
> 
> Me either.  I briefly looked at the code and it wasn't immediately obvious
> to me how to fix it - maybe it would be difficult (impossible?), as there's
> no real gtk_tree_view_collapse_row() equivalent to
> gtk_tree_view_expand_row().  The latter takes a 3rd argument, "open_all",
> whereas there's no "collapse_all" argument to the former.

There should be a way: there's a "collapse tree" signal which we could use to
recurse down the subtrees closing them, then just redraw (or something like
that).

Especially given what Jakub pointed out in comment 30, I'm thinking that we:

1) Mark these fixes to be back-ported to 1.10.2
2) Close this bug
3) Open an enhancement for a "Collapse subtrees" functionality since it appears
to have always been like this and it also affects the Qt port.

Barring complaints, I'll do that in a while.


You are receiving this mail because:
  • You are watching all bug changes.