[bugzilla-daemon@xxxxxxxxxxxxx]

Alexis La Goutte changed bug 8972

What	Removed	Added
CC		alexis.lagoutte@gmail.com

Comment # 3 on bug 8972 from Alexis La Goutte

Hi Jouni,

Look good

+    dscp_item = proto_tree_add_text(tree, tvb, offset, 2, "DSCP Exception");
[...]
+    dscp_item = proto_tree_add_text(tree, tvb, offset, 2,
+                                    "DSCP Range description");

it is possible to replace by proto_tree_add_item ? (with FT_NONE hf type ?)
(you try to remove proto_tree_add_text...)

+      expert_add_info_format(pinfo, item, PI_MALFORMED, PI_ERROR,
+                             "Invalid DSCP Value");
It is possible to use the new expert "framework" ? (i know 802.11 dissector is
not yet convert to the new "framework"

---

      You are receiving this mail because:

• You are watching all bug changes.