Comment # 9
on bug 8947
from Michael Mann
(In reply to comment #7)
> 2. Would you be willing to help make more items filterable in
> the COPS
> dissector? It's a little out of scope for this bug, but the COPS
> dissector
> has way too many proto_tree_add_text calls. There is a tool for
> converting
> them (convert_proto_tree_add_text.pl), but having someone more
> familiar with
> the protocol (which I'm not) helps for variable and display
> filter naming.
> 2. I'm aware of the proto_tree_add_text issue in packet-cops.c, I've ran
> checkAPIs.pl before I open this ticket and got warning of 69 useless
> add_test(). I was just not sure if I should fix them because they were there
> already :) I will be happy to do the cleanup, would you suggest I deliver
> them in this patch or open another one? IMO a dedicate patch would be more
> clear.
Discussion taken offline and will result in a separate bug report.
You are receiving this mail because:
- You are watching all bug changes.