Wireshark-bugs: [Wireshark-bugs] [Bug 8944] New: patch: (packet-scsi-osd.c) dissect LIST COLLECT

Date: Wed, 17 Jul 2013 18:59:51 +0000
Bug ID 8944
Summary patch: (packet-scsi-osd.c) dissect LIST COLLECTION service action
Classification Unclassified
Product Wireshark
Version SVN
Hardware All
OS All
Status UNCONFIRMED
Severity Enhancement
Priority Low
Component Dissection engine (libwireshark)
Assignee [email protected]
Reporter [email protected]

Build Information:

--
This patch adds support for dissection of the OSD-2 LIST COLLECTION service
action, and (OSD-1/OSD-2) LIST COLLECTION parameter data.

Proposal:
 * Remove dissect_osd_list_collection and dissect LIST COLLECTION by calling
dissect_osd_list.
 * Handle the few differences depending on the value of svcaction in extra
data.
 * dissect_osd_collection_object_id now returns proto_item* instead of void.

The following field was added:
 * hf_scsi_osd_list_collection_flags_coltn

The following true_false_string array was added
 * list_coltn_tfs

The dissector for the LIST service action is fully functional, and the only
differences between LIST and LIST COLLECTION are:
 * LIST have a SORT ORDER field. That field is reserved for LIST COLLECTION.
 * LIST COLLECTION have a COLLECTION ID field that is reserved in the LIST CDB.
 * The LIST response parameter data (OSD-1) have a ROOT field; the LIST
COLLECTION parameter data have a COLTN field in the same place
 * The LIST response parameter data (OSD-2) uses object descriptor codes 0x01,
0x02, 0x21, 0x22; the LIST COLLECTION response parameter data uses codes 0x11,
0x12, 0x21 and 0x22 (the meaning of codes 0x21 and 0x22 is the same for both
service actions).

Examples:
OSD-1: scsi-osd-example-001 in http://wiki.wireshark.org/SampleCaptures (LIST
response in frame 288)
OSD-2: attached (LIST and LIST COLLECTION)


You are receiving this mail because:
  • You are watching all bug changes.