Michael Mann
changed
bug 8849
| What |
Removed |
Added |
| Attachment #11192 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 23
on bug 8849
from Michael Mann
Comment on attachment 11192 [details]
packet-iec104 patch v6
2 issues:
1. By delaying populating the COL_INFO "until the end", you risk losing
COL_INFO data if a packet is malformed because dissection will abort before the
COL_INFO is populated. This is why the COL_INFO data was "individually"
populated before.
2. col_check has been deprecated and shouldn't be used. Also the functionality
surrounding it can be done in a single function call of col_append_sep_str().
(You'll still need the fence call though)
Also, not sure whitespace formatting on the #define/global variables is really
necessary and makes the patch much larger than it needs to be.
You are receiving this mail because:
- You are watching all bug changes.