Michael Mann
changed
bug 8912
| What |
Removed |
Added |
| Attachment #11176 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 7
on bug 8912
from Michael Mann
Comment on attachment 11176 [details]
Revised 11ac patch
Few other issues:
1. Patch makes whitespace inconsistency. Files appear to use just spaces and
no tabs.
2. C++ style comments in wiretap/vwr.c
3. Current implementation uses offsets from vwr_t structure. While I
understand this patch includes some refactoring, should those values really be
changed to being completely hardcoded? Perhaps changing them to #defines so
there is some indication as to what these offset values represent would be
better.
You are receiving this mail because:
- You are watching all bug changes.