Evan Huus
changed
bug 8860
| What |
Removed |
Added |
| Attachment #11085 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 2
on bug 8860
from Evan Huus
Comment on attachment 11085 [details]
Updated selfm Dissector from 06-27-2013
Hi Chris, I'm afraid the patch doesn't apply cleanly to trunk, please make sure
you rebase to the latest version.
Also, proto_tree_add_text effectively shouldn't be used unless you're building
a sub-tree under it. For functions where you use it with actual values, please
create an hf field and use the appropriate proto_tree_add_[type], where type is
int, uint, float, etc. If you need special formatting, use
proto_tree_add_[type]_format which takes printf-like arguments.
For items being added to the tree that don't come from the current packet (i.e.
they're reference values from the conversation, or other such things), please
use PROTO_ITEM_SET_GENERATED to mark them as such.
Just little things, otherwise it looks good.
Cheers,
Evan
You are receiving this mail because:
- You are watching all bug changes.