[bugzilla-daemon@xxxxxxxxxxxxx]

Evan Huus changed bug 8718

What	Removed	Added
CC		alexis.lagoutte@gmail.com

Comment # 42 on bug 8718 from Evan Huus

(In reply to comment #41)
> Thanks for your suggestions
> 
> 1) I don't understand your last item:
> > And finally, the parameter list of proto_register_zbee_zcl_appl_ctrl is formatted oddly.
> 
> why is formatted oddly?

Most functions you put the parameter list on the same line, eg:                 
    proto_reg_handoff_zbee_zcl_appl_ctrl(void)

That one is all across different lines for some reason:
    void proto_register_zbee_zcl_appl_ctrl
    (
      void
    )

Again, not a serious issue, just odd.

> 2) Why in the last commit packet-zbee-zcl-ha.c is modified?
> 
>   /* Check is this command has a payload, than add the payload tree */
>   (offset != (tvb_length(tvb) - 1)) {
>   /*payload_root = */proto_tree_add_text(tree, tvb, offset, tvb_length(tvb),
> "Payload");
>   /*payload_tree = proto_item_add_subtree(payload_root,
> ett_zbee_zcl_appl_evtalt);*/
>             }

Alexis (CCed now) fixed some warnings detected by our Clang buildbot in r50233.

---

      You are receiving this mail because:

• You are watching all bug changes.