Michael Mann
changed
bug 8869
| What |
Removed |
Added |
| Attachment #11102 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 3
on bug 8869
from Michael Mann
Comment on attachment 11102 [details]
Add VNC extensions: MirrorLink, LibVNCserver, H.264
2 minor issues:
1. Please use proto_tree_add_item(..., ENC_NA|ENC_ASCII) for your string items
instead of proto_tree_add_string() if there is no other use for the string
value (in doesn't appear to be in the cases I noticed).
2. col_set_str can be changed to col_add_fstr and you can fit all of the column
data formatting in one call.
Otherwise, looks very good.
You are receiving this mail because:
- You are watching all bug changes.