[bugzilla-daemon@xxxxxxxxxxxxx]

Jeff Morriss changed bug 8843

What	Removed	Added
Status	UNCONFIRMED	INCOMPLETE
CC		jeff.morriss.ws@gmail.com
Ever confirmed		1

Comment # 1 on bug 8843 from Jeff Morriss

A few comments:

That "if(!tree) return" statement needs to be removed because the column values
are set below that (column stuff must be set regardless of whether we have a
tree or not).

There are a couple new proto_tree_add_text()'s in here which look like they
should be adding real (filterable) items--why not use proto_tree_add_item()?

I think that tvb_length_remaining() call should actually be
tvb_reported_length_remaining() (in case there a capture is taken with a
snapshot length.

Also, could you provide a sample capture which demonstrates the new code?

---

      You are receiving this mail because:

• You are watching all bug changes.