Wireshark-bugs: [Wireshark-bugs] [Bug 8515] Global variables in X.400 P1 dissector considered ha

Date: Thu, 27 Jun 2013 02:25:58 +0000

changed bug 8515

What Removed Added
Attachment #11057 is obsolete   1
Attachment #11057 Flags review_for_checkin?  
Attachment #11078 Flags   review_for_checkin?

Comment # 9 on bug 8515 from
Created attachment 11078 [details]
Remove p1 global variables (v3)

Moved ContentType into "tree context".  Was getting a bit agressive making
ContentType part of the actx->exteral, I just saw that it was a const char* and
thought it could be there.  Looking back the report_unknown_content_type member
should have tipped me off to putting it there in the first place.

http://wiki.wireshark.org/SampleCaptures?action="">
now parses the same in v1.10 as it does with this patch applied.  With all of
the layers involved, I'm still nervous I haven't done enough testing.


You are receiving this mail because:
  • You are watching all bug changes.