[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	8849
Summary	Buggy IEC104 dissector caused by commit r48958
Classification	Unclassified
Product	Wireshark
Version	SVN
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	Major
Priority	Low
Component	Dissection engine (libwireshark)
Assignee	bugzilla-admin@wireshark.org
Reporter	engycz@gmail.com

Created attachment 11061 [details]
Patch for packet-iec104.c

Build Information:

--
Dissector for IEC104 contains several bugs caused by commit r48958 from Michael
Mann.
1) Wrong bits definitions for SIQ.BL, SIQ.SB, SIQ.NT, SIQ.IV, QDS.BL, QDS.SB,
QDS.NT, QDS.IV - fixed in patch
2) Invalid field abbrev for VTI Transient - fixed in patch
3) Wrong bit size for SCO.QU, DCO.QU, RCO.QU - fixed in patch
4) Changes from BASE_DEC to BASE_HEX - fixed in patch
5) Several code style changes - fixed in patch

6) Range of value in "Value with transient state (VTI)" is -64..63 (not 0..127)
- not fixed, register info doesn't support FT_INT8 with bit mask
DISSECTOR_ASSERT(!hfinfo->bitmask);
7) Decoding of CP56Time results in "Not representable" time - not fixed, I will
work on it tomorrow

Because I haven't commit rights, I ask someone to commit my patch to trunk and
to trunk-1.10.

Also I will check all info object types against ICE 60870-5-104 specification.

Regards
  Jiří Engelthaler

---

      You are receiving this mail because:

• You are watching all bug changes.