Comment # 31
on bug 8718
from Evan Huus
Just a few little pieces of code style for this one:
- Don't use (void)name to hide unused parameters, use the _U_ designator, for
example:
static void
dissect_zbee_zcl_illum_meas(tvbuff_t *tvb, packet_info *pinfo, proto_tree
*tree)
{
(void)tvb;
(void)pinfo;
(void)tree;
can be just:
static void
dissect_zbee_zcl_illum_meas(tvbuff_t *tvb _U_, packet_info *pinfo _U_,
proto_tree *tree _U_)
{
- There's no reason to cast constants to int when they're small, for example:
*offset += (int)2;
can be just:
*offset += 2;
- Please update the makefiles (epan/dissectors/Makefile.common and
epan/CMakelists.txt) to include the new files, otherwise they don't get build.
Thanks,
Evan
You are receiving this mail because:
- You are watching all bug changes.