[bugzilla-daemon@xxxxxxxxxxxxx]

Jakub Zawadzki changed bug 2577

What	Removed	Added
CC		darkjames-ws@darkjames.pl

Comment # 5 on bug 2577 from Jakub Zawadzki

Hi Kees,

this looks strange:

+    else if (!g_strcmp0(mac_name,"hmac-md5"))
+        global_data->mac_length = 12;

shouldn't it be: mac_length = 16?

Quoting rfc4253:
#v+
   The following MAC algorithms are currently defined:

      hmac-sha1    REQUIRED        HMAC-SHA1 (digest length = key
                                   length = 20)
      hmac-sha1-96 RECOMMENDED     first 96 bits of HMAC-SHA1 (digest
                                   length = 12, key length = 20)
      hmac-md5     OPTIONAL        HMAC-MD5 (digest length = key
                                   length = 16)
      hmac-md5-96  OPTIONAL        first 96 bits of HMAC-MD5 (digest
                                   length = 12, key length = 16)
      none         OPTIONAL        no MAC; NOT RECOMMENDED
#v-

Please look on this,

Thanks,
Jakub.

---

      You are receiving this mail because:

• You are the assignee for the bug.
• You are watching all bug changes.