Comment # 20
on bug 8718
from Evan Huus
(In reply to comment #19)
> I have merged the two patch in a single one. Is it mandatory I have to split
> the patch to 2 single patches ?
Not mandatory, but it will make it easier to review. I've taken a look at some
of the obviously new stuff in the patch and I have a few minor comments:
- Don't use (void)name to hide unused parameters, use the _U_ designator, for
example: void func(int myParam _U_, int myOtherParam)
- There's no reason to use sizeof(guint8) everywhere in your
proto_tree_add_item calls, it will always be 1.
- Please update the makefiles (epan/dissectors/Makefile.common and
epan/CMakelists.txt) to include the changes.
You are receiving this mail because:
- You are watching all bug changes.