[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	8786
Summary	patch: dissect SCSI descriptor format sense data (dissect_scsi_descriptor_snsinfo)
Classification	Unclassified
Product	Wireshark
Version	SVN
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	Minor
Priority	Low
Component	Dissection engine (libwireshark)
Assignee	bugzilla-admin@wireshark.org
Reporter	uce@rjgodoy.com.ar

Created attachment 10957 [details]
Example

Build Information:

--
For reference, see section 4.5.2 of SPC-4r36 (Descriptor format sense data)

Descriptor format sense data has an 8-byte header. Byte 7 is the additional
sense length. Sense key, and additional sense code/qualifier are actually
dissected by dissect_scsi_descriptor_snsinfo. The remaining bytes are sense
data descriptor entries.

Sense data descriptors may be further dissected depending on their type.
The sense key specific descriptor (type 02h) contains a "sense key specific
information" field that is similar to the same field in the fixed format sense
data. 

In this patch, the only descriptor type that receives additional processing is
02h.

Changes: 
 1. There is no "Valid" field when the sense data has descriptor format. That
field is only defined for fixed format sense data, and must be 0 for descriptor
format sense data.
 => Move proto_tree_add_text of "Valid:" to dissect_scsi_fix_snsinfo.

 2. Dissect sense data descriptors in dissect_scsi_descriptor_snsinfo.

 4. The following fields were defined:
   - hf_scsi_sns_desc_type (Sense data descriptor type) 
   - hf_scsi_sns_desc_length (Sense data descriptor length)

 5. The following trees were added
   - ett_sense_descriptor 

 6. The following value_string arrays were added:
   - scsi_sense_desc_type_val

The sample capture contains a single Check Condition response with two
descriptors.

---

      You are receiving this mail because:

• You are watching all bug changes.