Wireshark-bugs: [Wireshark-bugs] [Bug 8635] enhanced WCCP decoder

Date: Wed, 05 Jun 2013 09:39:00 +0000

Comment # 17 on bug 8635 from
(In reply to comment #15)
> CID 1026572 (#1 of 1): Logically dead code (DEADCODE)dead_error_condition:
> On this path, the condition "length < 0" cannot be true.
> 2597    if (length < 0)

Correct, in the loop we have:
  NOTE_EATEN_LENGTH(new_length);

which expands in 
  {if (new_length<0) return new_length;  offset += length-new_length; length =
new_length; }

 so length cannot be <0.

The same for:

> 2841      if (length < 0)
> 2496      if (length < 0)

Fixed those as well.

> CID 1026709 (#2 of 2): Unused pointer value (UNUSED_VALUE)returned_pointer:
> Pointer "method_tree" returned by "proto_item_add_subtree(tm, ett)" is never
> used.
> 2763      method_tree = proto_item_add_subtree(tm, ett);

Correct. Removed a few copies of this error.


You are receiving this mail because:
  • You are watching all bug changes.