Michael Mann
changed
bug 8020
| What |
Removed |
Added |
| Attachment #10899 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 20
on bug 8020
from Michael Mann
Comment on attachment 10899 [details]
Updated patch which uses expert_info api
I would have to say, yes please use the new (filterable) expert info API.
There are numerous examples in the current SVN, for your case I would consider
packet-arp.c and/or packet-bootp.c
It looks like most (if not all?) of your expert info falls under "invalid
length", so I would probably just create a single "expert info item" (similar
to the hf items), and use expert_add_info_format_text to "format" to the exact
string mentioning the length. You could create individual "expert info items"
for each case (using expert_add_info), but that's probably overkill (unless you
think the dissector needs it)
You are receiving this mail because:
- You are watching all bug changes.