Comment # 11
on bug 8735
from Tyson Key
Thanks Michael,
It took me a while to digest all of the changes, so early in the morning - but
other than a stray col_set_str() it looks fine, I think.
Not a complaint, but I'd be tempted to move the friendly descriptions into
their own table, and just use the list of message types to describe opcodes -
although that's not a big deal, right now. Still, cleaning up the code is
always a Good Thing(TM).
The new length-handling bits seem good, and there aren't any malformed packets
caught by CCID if I use a display filter.
Tyson.
(In reply to comment #10)
> Created attachment 10872 [details]
> patch with corrected length, column optimization
>
> Tyson,
>
> What do you think of this patch? It makes the length a true 32-bit value,
> and uses it to determine if subdissectors should be called. I also
> optimized the INFO column setting.
You are receiving this mail because:
- You are watching all bug changes.