Alexis La Goutte
changed
bug 8691
| What |
Removed |
Added |
| OS |
Mac OS X 10.8
|
All
|
Comment # 6
on bug 8691
from Alexis La Goutte
(In reply to comment #4)
> BTW: checking on BGP files, there are 205 use of proto_tree_add_text and 141
> match for proto_tree_add_item.
It is only for information.
Use proto_tree_add_text is not recommended (It is prefered to use
proto_tree_add_item.
The BGP dissector need a big cleanup to change all proto_tree_add_text by
proto_tree_add_item (or others)
>
> So what is driving the choice between one or the other ?
>
> There are many case where I just but explanation of the purpose of the
> protocol field and doing a simple decimal decoding: I though it would be
> best way to go and avoid me to go through hf déclaration... For all other
> complex decoding I did use hf and proto_tree_add_item or boolean.
It is prefered to create a hf declartion for each field (the field is
filtereable and the code is more easy to read after...)
>
> Please let me know ... feel free to point me to concret example I should
> change my approach.
>
> Thanks,Matt.
You are receiving this mail because:
- You are watching all bug changes.