Pascal Quantin
changed
bug 8644
| What |
Removed |
Added |
| CC |
|
[email protected]
|
| Version |
1.9.x (Experimental)
|
1.11.x (Experimental)
|
Comment # 5
on bug 8644
from Pascal Quantin
Hi Chris,
you will find below a few comments:
- the header lacks the $Id$ SVN keyword
- it might be better to move your dissector notes out of the Wireshark header
template
- you can remove the inclusion of packet-tcp.h and epan/packet-expert.h
- change dissect_rtacser() to return the number of bytes consumed instead of a
boolean. See new_dissector_t definition. The TRUE/FALSE return code is used for
heuristic dissectors
- If you request an official DLT/LINKTYPE value as suggested by Guy and add a
preference allowing the user to select the sub dissector to be called (selfm,
mbrtu, dnp3.udp, synphasor, ...), it would allow you to get rid of all the
manual configuration in DLT_USER preferences
You are receiving this mail because:
- You are watching all bug changes.