Wireshark-bugs: [Wireshark-bugs] [Bug 8636] Wrong Fibre Channel EOFs in dissector

Date: Wed, 08 May 2013 14:41:03 +0000

Comment # 2 on bug 8636 from
(In reply to comment #1)
> I just tried to understand the values by looking at the spec (I'm not at all
> familiar with fibre channel). Are the values you changed refering to 8B/10B,
> can they be derived from the Kxx.x and Dxx.x sequences (which are 10bit
> each)?

Yes, they can - K28.5 = 0xBC to name one.
Dxx.y is decodes as yyyxxxxx in binary - so D10.5 is 101 01010 (10101010 =
0xAA).
Dxx.y or Kxx.y are treated the same in the dissector as the control bit is
never propagated from the source.

Also, have a look at http://www.tcpdump.org/linktypes.html under
LINKTYPE_FC_2_WITH_FRAME_DELIMS.
"The encodings represent the frame delimiters as 4-byte sequences representing
the corresponding ordered sets, with K28.5 represented as 0xBC, and the D
symbols as the corresponding byte values; for example, SOFi2, which is K28.5 -
D21.5 - D1.2 - D21.2, is represented as 0xBC 0xB5 0x55 0x55."

> 
> Thanks for your help and sorry for being picky. I'd like to have at least a
> basic understanding before I commit something.
No problem at all! I welcome the review, you never know if I missed something.


You are receiving this mail because:
  • You are watching all bug changes.