Wireshark-bugs: [Wireshark-bugs] [Bug 7060] Global variables - Buildbot crash output: fuzz-2012-

Date: Fri, 03 May 2013 09:21:27 +0000

Comment # 14 on bug 7060 from
(In reply to comment #13)
> (In reply to comment #11)
> > (Not that this shouldn't be done
> > - Global Variables Considered Harmful - but that we need to be careful when
> > we do so.  Maybe I should try one of my big regression tests between the
> > code without this change and the code with it.)
> 
> Are these big regression tests sharable generally or on the wiki already
> somewhere? Or are they not automated?

The files are a combination of non-public capture I have, wireshark.org's
"Wireshark menagerie" also used as source files for fuzz-testing (composed of
captures harvested from bugs - Gerald, are they also harvested from mailing
lists and/or sample captures on the Wiki?), and various old files from various
sets of sample captures for other analyzers.

I suspect most of the interesting problems show up with captures in the
menagerie.

The scripts are fairly dumb scripts that:

    run "before" and "after" versions of "tshark -V", piping them into "cmp"
and, if "cmp" says they're not the same, runs those versions again, with the
standard output sent to "/tmp/before" and "/tmp/after", and diffs them;

    does a recursive "find" and runs the aforementioned script on the capture
files it finds.

The first of those scripts could use a little generalization - right now, every
time I have a new "wireshark.XXX" directory and a "wireshark.XXX-baseline"
directory, I copy the script and tweak it to look for
../wireshark.XXX-baseline/tshark" and compare its output with that of "tshark".

(They also will, for a capture file named foo, look for a foo.options file and,
if it finds it, sticks its contents into the tshark command lines, to set
options with "-o".)

The results aren't available on the Web - the test machine is a laptop and is
clamshelled when I'm not using it, so it's not going to be much of a server.


You are receiving this mail because:
  • You are watching all bug changes.