Jörg Mayer
changed
bug 8616
| What |
Removed |
Added |
| Status |
RESOLVED
|
INCOMPLETE
|
| Resolution |
FIXED
|
---
|
| Ever confirmed |
|
1
|
Comment # 10
on bug 8616
from Jörg Mayer
Using the bugtracker is easier, that way the patches and the discussion don't
get lost.
I ran some checks from doc/README.developer section 1.11 (Submitting code for
your new dissector.)
Two of the checks generated output:
jmayer@egg:~/work/wireshark/svn/trunk/epan/dissectors> ../../tools/checkhf.pl
packet-skinny.c
ERROR: NO ARRAY: packet-skinny.c, hf_skinny_speedDialInstance
ERROR: NO ARRAY: packet-skinny.c, hf_skinny_speedDialStatus
ERROR: NO ARRAY: packet-skinny.c, hf_skinny_speedDialType
ERROR: NO ARRAY: packet-skinny.c, hf_skinny_startMediaTransmissionStatus
ERROR: NO ARRAY: packet-skinny.c, hf_skinny_startMultiMediaTransmissionStatus
This means that the necessary entries in the hf_ array are missing.
This is critical as it will create an abort or whatever when such a message is
encountered. Please fix.
The second complaint is
jmayer@egg:~/work/wireshark/svn/trunk/epan/dissectors>
../../tools/checkfiltername.pl packet-skinny.c
packet-skinny.c (18 (of 253) fields)
cast.lastRedirectingPartyName doesn't match PROTOABBREV of skinny
[...]
cast.partyPIRestrictionBits.LastRedirectPartyNumber doesn't match PROTOABBREV
of skinny
TOTAL ERRORS: 18
This is old stuff so don't mind it.
You are receiving this mail because:
- You are watching all bug changes.