Comment # 21
on bug 8613
from Alexis La Goutte
Comment on attachment 10674 [details]
ieee80211: Dissect TFS Request/Response
+static const value_string tfs_response_subelem_ids[] = {
+ { 1, "TFS Status subelement" },
+ { 2, "TFS subelement" },
+ { 221, "Vendor Specific subelement" },
It is possible to add some #define ? (reused in if (id == X...)
The code will be more easy to understood..
Why don't replace if by switch ?
Also replace proto_tree_add_text by proto_tree_add_item
You are receiving this mail because:
- You are watching all bug changes.