[bugzilla-daemon@xxxxxxxxxxxxx]

Alexis La Goutte changed bug 8592

What	Removed	Added
CC		alexis.lagoutte@gmail.com

Comment # 3 on bug 8592 from Alexis La Goutte

Additional review :

The code don't compile under my Ubuntu Box (with GCC)

packet-dhcpv6.c: In function 'dissect_packetcable_cccV6_option':
packet-dhcpv6.c:880:22: error: declaration of 'i' shadows a previous local
[-Werror=shadow]
packet-dhcpv6.c:837:10: error: shadowed declaration is here [-Werror=shadow]
packet-dhcpv6.c:886:25: error: request for implicit conversion from 'void *' to
'gchar *' not permitted in C++ [-Werror=c++-compat]
packet-dhcpv6.c:907:17: error: comparison of unsigned _expression_ < 0 is always
false [-Werror=type-limits]
packet-dhcpv6.c:954:22: error: declaration of 'i' shadows a previous local
[-Werror=shadow]
packet-dhcpv6.c:837:10: error: shadowed declaration is here [-Werror=shadow]
packet-dhcpv6.c:961:25: error: request for implicit conversion from 'void *' to
'gchar *' not permitted in C++ [-Werror=c++-compat]
packet-dhcpv6.c:982:17: error: comparison of unsigned _expression_ < 0 is always
false [-Werror=type-limits]
packet-dhcpv6.c: In function 'dissect_cablelabs_specific_opts':
packet-dhcpv6.c:1072:17: error: request for implicit conversion from 'void *'
to 'gchar *' not permitted in C++ [-Werror=c++-compat]
packet-dhcpv6.c:1094:56: error: ordered comparison of pointer with integer zero
[-Werror=extra]
packet-dhcpv6.c:1195:25: error: suggest parentheses around assignment used as
truth value [-Werror=parentheses]
packet-dhcpv6.c:1197:25: error: suggest parentheses around assignment used as
truth value [-Werror=parentheses]
packet-dhcpv6.c:1199:25: error: suggest parentheses around assignment used as
truth value [-Werror=parentheses]

It is not possible to create a header field (hf) for each suboption type ?

---

      You are receiving this mail because:

• You are watching all bug changes.