Comment # 14
on bug 8573
from O B
Thanks for the code review Evan.
(In reply to comment #12)
> Would one of you like to extract some common code into a separate patch that
> can be merged first, or would you prefer the two dissectors are committed
> separately and then common code added later?
I'd prefer to commit them first then merge them in a future patch.
One thing I have questions about. The Percision Time Protocol dissector also
is abbrievated PTP. For the common code between both PTP/USB & PTP/IP would
there be any issue labeling it PTP?
The sizeof(variable) approach I was using for code legability. I'll change that
and work on your other recommendations. Hopefully I'll get the indentation
right this time. As I said before my IDE is being a pain with that.
Thanks again,
0xB
You are receiving this mail because:
- You are watching all bug changes.