[bugzilla-daemon@xxxxxxxxxxxxx]

Evan Huus changed bug 8592

What	Removed	Added
Status	UNCONFIRMED	INCOMPLETE
CC		eapache@gmail.com
Ever confirmed		1

Comment # 2 on bug 8592 from Evan Huus

Hi Brian, thanks for the patch. In general it looks really good, I just a have
a few quick questions:

- You do something very similar with strings in the PKT_CCCV6_KRB_REALM and
PKT_CCCV6_IETF_PROV_SRV cases. I'm wondering if the common part could be
extracted into a separate function that the two cases both call?

- I'm also wondering if it would be possible to use a wmem_strbuf rather than a
raw buffer. I think it does everything you need, and would save you from
keeping track of all the offsets yourself.

- The creation and use of tvb_tmp seems unnecessary? I think you can just
adjust the offset used in accesses to the regular tvb.

Thanks,
Evan

---

      You are receiving this mail because:

• You are watching all bug changes.