[bugzilla-daemon@xxxxxxxxxxxxx]

Evan Huus changed bug 8594

What	Removed	Added
Status	UNCONFIRMED	INCOMPLETE
CC		eapache@gmail.com
Ever confirmed		1

Comment # 4 on bug 8594 from Evan Huus

Hi Jalil, in general it looks fine.

However, I noticed you do a lot of proto_tree_add_bool and proto_tree_add_uint
with data retrieved unmodified from the tvb. In this case it is faster and more
efficient to simply use proto_tree_add_item and let Wireshark handle fetching
the data. For those fields that are only a few bits you can add a bitmask to
the hf array entries instead of manually masking in the dissector code.

Thanks,
Evan

---

      You are receiving this mail because:

• You are watching all bug changes.