Wireshark-bugs: [Wireshark-bugs] [Bug 8505] openSAFETY: New reassemble functionality, as well as

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 11 Apr 2013 15:11:43 +0000

Comment # 33 on bug 8505 from 
Yes, damn. Don't know how I missed that. Can it be changed during submission,
or should I send another patch?

Kind regards, Roland

(In reply to comment #32)
> By accident I also spotted what seems to be a copy/paste error.
> Shouldn't the hunk:
> 
> +    prefs_register_bool_preference(opensafety_module,
> "network_udp_frame_first_sercosiii",
> +                "openSAFETY frame 2 before frame 1 (SercosIII/UDP only)",
> +                "In an SercosIII/UDP transport stream, openSAFETY frame 2
> will be expected before frame 1",
> +                &global_udp_frame2_first );
> 
> be:
> 
> +    prefs_register_bool_preference(opensafety_module,
> "network_udp_frame_first_sercosiii",
> +                "openSAFETY frame 2 before frame 1 (SercosIII/UDP only)",
> +                "In an SercosIII/UDP transport stream, openSAFETY frame 2
> will be expected before frame 1",
> +                &global_siii_udp_frame2_first );
> 
> ?

You are receiving this mail because:
  • You are watching all bug changes.