Comment # 2
on bug 8573
from Jaap Keuter
Quick review:
* Keep the tabs in Makefile.common
* No checks on column needed, just set them
* Never enclose setting of column by "if (tree)'
* Never enclose calling a subdissector by "if (tree)'
* Don't go around getting values, only to add them to the tree unchanged.
Define a proper header field and use proto_tree_add_item()
* Do not check tvb_length_remaining() all the time.
The TVB covers all that for you, and btw it's done wrong.
* If you insist using tabs in your source lines you have to include modelines
You are receiving this mail because:
- You are watching all bug changes.