Comment # 3
on bug 8565
from Masatake YAMATO
(In reply to comment #2)
> Comment on attachment 10553 [details]
> The dissector
>
> Quick review:
>
> * If you are determining endianness, you don't need 4 entries in
> pulse_magic_type
> * You may want to use try_val_to_str() i.s.o. val_to_str()
> * Use of check_col() is deprecated, you can drop them
> * Calling col_set_str() inside an 'if (parent_tree)' block is a no-no
> * proto_tree_add_item() no longer takes gboolean
Thank you for reviewing. I have revised my patch based on your comment.
You are receiving this mail because:
- You are watching all bug changes.