[bugzilla-daemon@xxxxxxxxxxxxx]

Chris Maynard changed bug 8506

What	Removed	Added
Status	RESOLVED	INCOMPLETE
Resolution	FIXED	---

Comment # 28 on bug 8506 from Chris Maynard

(In reply to comment #26)
> Created attachment 10501 [details]
> Bugfix patch improved
> 
> Referring to comment #c25: it was not intentional. Fixed by this patch.

Regarding the FT_BOOLEAN changes, this patch looks wrong to me.  The bitmasks
should not be zero according to
http://wdv.com/Electronics/Reference/SDROoverWEB-VITA.pdf.

And from doc/README.developer:
                --For FT_BOOLEAN:

                  if BITMASK is non-zero:
                    Number of bits in the field containing the FT_BOOLEAN
                    bitfield.
                  otherwise:
                    (must be) BASE_NONE

So using hf_vrt_trailer_e as an example, the proper change probably should have
been either:

        { &hf_vrt_trailer_e,
            { "Associated context packet count enabled", "vrt.e",
            FT_BOOLEAN, 8,
            NULL, 0x80,
            NULL, HFILL }
        },

or:
        { &hf_vrt_trailer_e,
            { "Associated context packet count enabled", "vrt.e",
            FT_BOOLEAN, 32,
            NULL, 0x80,
            NULL, HFILL }
        },

... depending on whether you want to group 'e' within the entire 32-bit trailer
or just the last byte of the trailer.  Looking at the specification quickly
(and without any experience with this protocol), it seems to make more sense to
me to group it with the entire 32-bits of the trailer.  And the display filter
might be better off as, "vrt.trailer.e".  Similarly for the others.

---

      You are receiving this mail because:

• You are watching all bug changes.