Evan Huus
changed
bug 8505
| What |
Removed |
Added |
| Status |
INCOMPLETE
|
CONFIRMED
|
Comment # 27
on bug 8505
from Evan Huus
(In reply to comment #24)
> Comment on attachment 10524 [details]
> openSAFETY: New reassemble, minor changes to SPDO, SSDO and SNMT
>
> Found one more bug/mishap.
>
> Reassembly only works in wireshark, if the whole packet is dissected during
> the initial inspection. If you only add the reassembly if the main
> proto_tree != NULL (aka detail view for package), reassembly fails in
> wireshark, but tshark for instance works fine. Documentation is really
> unclear about that, as the default example uses an if(tree) clause to
> determine if it should enable deeper inspection or not.
Yes, the only things that may be conditional on tree!=NULL are proto_tree_*
calls. Everything else must happen regardless. I will add cleaning up that
documentation to my TODO list, the behaviour used to be different so I'm not
surprised there are inconsistencies.
I'm pretty busy right now so I may not have a chance to review the new patch
for a while. Marking this as CONFIRMED so somebody else can pick it up if they
want. If not I'll get to it when my exams are over.
Sorry for the delay,
Evan
You are receiving this mail because:
- You are watching all bug changes.