Michael Mann
changed
bug 8547
What |
Removed |
Added |
Attachment #10515 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 2
on bug 8547
from Michael Mann
Comment on attachment 10515 [details]
An initial version of a "stub" dissector for the CryptoRF protocol
Two issues:
1. Column data should be tree independent (ie shouldn't be in a if (tree)
block)
2. Use val_to_str when setting the COL_INFO, so you don't need the switch
statement. I realize the switch statement is stubbed for the commands, but it
should never be individually setting the commands in COL_INFO anyway.
You are receiving this mail because:
- You are watching all bug changes.