Michal Labedzki
changed
bug 8509
| What |
Removed |
Added |
| Attachment #10502 is obsolete |
|
1
|
| Attachment #10502 Flags |
review_for_checkin?
|
|
| Attachment #10509 Flags |
|
review_for_checkin?
|
Comment # 20
on bug 8509
from Michal Labedzki
Created attachment 10509 [details]
[PATCH 2] Bluetooth: Fix and improve SDP, part 2
(In reply to comment #19)
> Patch 2 looks pretty good. I'm seeing two small issues with it:
>
> - Everywhere you do g_snprintf(str + strpos, MAX_SDP_LEN, *) it should I
> think be g_snprintf(str + strpos, MAX_SDP_LEN - strpos, *), since g_snprintf
> doesn't otherwise know how much of the beginning of str is being skipped?
Thanks. Fixed.
> - My GCC warns: packet-btsdp.c:1656:29: error: 'value_offset' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
Hmm.. My gcc 4.6.0 is shy :) Ubuntu 12.04 GCC 4.4 and GCC 4.6 too.
Real issue. Fixed. Thanks.
You are receiving this mail because:
- You are watching all bug changes.