Evan Huus
changed
bug 8505
| What |
Removed |
Added |
| Status |
CONFIRMED
|
IN_PROGRESS
|
Comment # 18
on bug 8505
from Evan Huus
OK, so I think I understand it now.
(In reply to comment #15)
> I did not want to present the unxor'd code in a
> separate tvb section. The reason behind it is, that someone might look at
> the bytes as they have been transmitted in other parts of the fieldbus
> system. Our company uses some inner-machine protocols on a pci-bus
> implementation, and there we see the same bytes in the same order.
There is a way (I think) to present the original and unxor'd bytes in 'sibling'
tvbs so that the user can see whichever they wish and how the dissection
relates to both. I think that would do what you need with respect to display
and decoding, and would also do what I want with respect to using wireshark's
existing functionality. However, I'm not familiar with that part of the API and
it would be a fairly substantial change.
I will review (and probably commit) the current patch as-is. I'll be happy to
accept a follow-up patch that does nice things with the tvbs, but I understand
at this point you probably don't have a whole lot of desire for the extra work
:)
Cheers,
Evan
You are receiving this mail because:
- You are watching all bug changes.